Skip to content

Commit ed8a639

Browse files
jfrag1sfirke
authored andcommitted
fix(import): Make sure query context is overwritten for overwriting imports (apache#25493)
1 parent e348326 commit ed8a639

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

superset/charts/commands/importers/v1/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,6 @@ def _import(
9595
config["params"].update({"datasource": dataset.uid})
9696

9797
if "query_context" in config:
98-
del config["query_context"]
98+
config["query_context"] = None
9999

100100
import_chart(session, config, overwrite=overwrite)

superset/commands/importers/v1/assets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def _import(session: Session, configs: dict[str, Any]) -> None:
117117
dataset_uid = f"{dataset_dict['datasource_id']}__{dataset_dict['datasource_type']}"
118118
config["params"].update({"datasource": dataset_uid})
119119
if "query_context" in config:
120-
del config["query_context"]
120+
config["query_context"] = None
121121
chart = import_chart(session, config, overwrite=True)
122122
chart_ids[str(chart.uuid)] = chart.id
123123

superset/dashboards/commands/importers/v1/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def _import(
118118
dataset_uid = f"{dataset_dict['datasource_id']}__{dataset_dict['datasource_type']}"
119119
config["params"].update({"datasource": dataset_uid})
120120
if "query_context" in config:
121-
del config["query_context"]
121+
config["query_context"] = None
122122

123123
chart = import_chart(session, config, overwrite=False)
124124
chart_ids[str(chart.uuid)] = chart.id

0 commit comments

Comments
 (0)