Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set $ definitions by API #119

Closed
jpcima opened this issue Mar 13, 2020 · 4 comments
Closed

Set $ definitions by API #119

jpcima opened this issue Mar 13, 2020 · 4 comments
Labels
new feature Feature additions and requests

Comments

@jpcima
Copy link
Collaborator

jpcima commented Mar 13, 2020

Provide API that can set $-variables prior to entering the parser.

This can be useful in some scenarios:

@paulfd paulfd self-assigned this Mar 14, 2020
@paulfd paulfd added the new feature Feature additions and requests label Mar 14, 2020
@paulfd
Copy link
Member

paulfd commented Mar 14, 2020

Overall maybe we should revisit the parser and the bindings between the synth and parser, cf your discussions of 20-13-03 evening on using sfizz programmatically. In essence the synth acts on a set of regions and some "global" information like root directories for samples. There's nothing that limits this to sfz files. However this will require some addition and overhaul in the API. The user-facing API of the library will need to be densified and we should describe how we would like to do this so it's stable enough.

@paulfd paulfd removed their assignment Apr 2, 2020
@paulfd
Copy link
Member

paulfd commented Apr 2, 2020

With the new parser code in #130 this is now possible, I'll close this, thanks for the PR !

@paulfd paulfd closed this as completed Apr 2, 2020
@jpcima
Copy link
Collaborator Author

jpcima commented Apr 2, 2020

With the new parser code in #130 this is now possible,

Not yet from sfizz API, is it ?

@jpcima jpcima reopened this Apr 2, 2020
@paulfd
Copy link
Member

paulfd commented Apr 2, 2020

Okay, I thought this support was mostly intended to be internal to e.g. support reading ARIA's banks, and not necessarily accessible from the API. Sorry for the overeager closing!

@paulfd paulfd added this to the 0.4.0 milestone Apr 2, 2020
@paulfd paulfd closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Feature additions and requests
Projects
None yet
Development

No branches or pull requests

2 participants