Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut silent audio files #465

Closed
jpcima opened this issue Sep 30, 2020 · 1 comment · Fixed by #831
Closed

Shortcut silent audio files #465

jpcima opened this issue Sep 30, 2020 · 1 comment · Fixed by #831
Assignees
@paulfd
Labels
improvement Improve on existing functionality

Comments

@jpcima
Copy link
Collaborator

jpcima commented Sep 30, 2020

If the sample fills in the preload in entirety, and it's all 0, replace it with *silence.
The reason to use silence.wav files instead of *silence is to provide compatibility with other players.
@paulfd paulfd added the improvement Improve on existing functionality label Nov 20, 2020
@paulfd paulfd added this to the 0.5.2 milestone Nov 20, 2020
@paulfd paulfd self-assigned this Nov 20, 2020
@paulfd
Copy link
Member

paulfd commented Apr 6, 2021 •
edited
Loading

Note that silent voices still "play", since they're used to trigger release regions as necessary.

@paulfd paulfd mentioned this issue Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulfd paulfd

Labels
improvement Improve on existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Small, all zero files are replaced by *silence paulfd/sfizz
2 participants
@paulfd @jpcima