Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note_polyphony=1 didn't mute on release trigger #529

Closed
kinwie opened this issue Oct 28, 2020 · 4 comments · Fixed by #634
Closed

note_polyphony=1 didn't mute on release trigger #529

kinwie opened this issue Oct 28, 2020 · 4 comments · Fixed by #634
Assignees
Labels
bug Something isn't working

Comments

@kinwie
Copy link

kinwie commented Oct 28, 2020

While adding polyphony=1 did make the "attack" and "release" triggered regions muted/choke each other (bi-directional), there is an issue it won't choke when using note_polyphony=1 instead.
A simple example :

//crash on attack
<group> key=60 note_polyphony=1
<region> sample=crash.wav loop_mode=one_shot
<region> sample=snare.wav trigger=release

//crash on release
<group> key=62 note_polyphony=1
<region> sample=snare.wav loop_mode=one_shot
<region> sample=crash.wav trigger=release
@paulfd
Copy link
Member

paulfd commented Nov 12, 2020

note_polyphony uses a separate code_path, I guess I'll get on it ;)

@kinwie
Copy link
Author

kinwie commented Nov 13, 2020

@paulfd Nice, thanks

@paulfd paulfd self-assigned this Nov 20, 2020
@paulfd paulfd added the bug Something isn't working label Nov 20, 2020
@paulfd paulfd added this to the 0.5.2 milestone Nov 20, 2020
@paulfd
Copy link
Member

paulfd commented Feb 8, 2021

Right now attack regions and release regions are checked separately for note_polyphony. We should have release regions potentially mask out attack regions then?

@kinwie
Copy link
Author

kinwie commented Feb 9, 2021

@paulfd Yes and vice versa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants