Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style #79

Closed
jpcima opened this issue Feb 25, 2020 · 3 comments
Closed

Code style #79

jpcima opened this issue Feb 25, 2020 · 3 comments

Comments

@jpcima
Copy link
Collaborator

jpcima commented Feb 25, 2020

It's not clear which code style must be adopted for contributing.
It would be nice to settle for one, and introduce a clang-format configuration for the whole source.

The most frequent that I can see is reminiscent of Stroustrup's style from C++ guidelines.

But there's some files, like lv2/sfizz.c, which mix different kinds of "*" and "{" placement, and make it extremely confusing.

@paulfd
Copy link
Member

paulfd commented Feb 26, 2020

IIRC the C++ part should be close to clang-format "WebKit". I'm easily influenced for these things, so since I started this project with JUCE I tended to use their naming approach, and when coding the LV2 part I fell back to the more usual C style naming that I also use in Python.

I have no strong feeling on these matters, so I agree with the idea of settling for one. If it's a default and common clang-format one, even better.

@jpcima
Copy link
Collaborator Author

jpcima commented Feb 29, 2020

A style file based on Webkit was added in the root.

@jpcima jpcima closed this as completed Feb 29, 2020
@redtide
Copy link
Member

redtide commented Feb 29, 2020

Ouch sorry I forgot about this, that was in 814020a.
We need to document this for contributors I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants