Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing = for #define #903

Open
kinwie opened this issue May 23, 2021 · 1 comment
Open

Allowing = for #define #903

kinwie opened this issue May 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kinwie
Copy link

kinwie commented May 23, 2021

This is working in sforzando and Cakewalk DropZone, DP and RP

#define $rootkey pitch_keycenter=64
#define $lokey lokey=64
#define $hikey hikey=64

<region>
sample=snare.wav
loop_mode=one_shot
$rootkey
$lokey
$hikey
@jpcima
Copy link
Collaborator

jpcima commented May 23, 2021

There are some worse cases documented in the parser issue #225, on which this must be a subset probably.
The conclusion which I come to, it's that the # elements of SFZ and $ variables should be be preprocessed in a first step.
Then one must take special care to preserve the line and column positions for diagnostics.

@paulfd paulfd added the bug Something isn't working label Nov 22, 2021
@paulfd paulfd added this to the 1.2.0 milestone Nov 22, 2021
@paulfd paulfd removed this from the 1.2.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants