Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to skip package installation #19

Closed
disconn3ct opened this issue Jun 23, 2016 · 5 comments
Closed

No option to skip package installation #19

disconn3ct opened this issue Jun 23, 2016 · 5 comments

Comments

@disconn3ct
Copy link

We use another module that installs the package but does minimal configuration. Since there is no option to skip package installation, we are getting duplicate resource errors. (Using ensure_packages would solve it without major changes.)

@disconn3ct disconn3ct mentioned this issue Jun 23, 2016
@sgnl05
Copy link
Owner

sgnl05 commented Sep 2, 2016

Wouldn't it be sufficient to include sssd::config and sssd::service instead of the main class?

@disconn3ct
Copy link
Author

Maybe I'm missing something (not the first time by far) but doesn't that make it impossible to override sssd::params without switching over to Hiera?

@tdevelioglu
Copy link

Better let the sssd::config and sssd:service stay private (preferably even unparameterized) and let only the public interface(s) allow configuring the parameters of the module.

I propose adding a $package_manage flag (default: true) to the main class that can prevent declaring the package resource.

@dannygoulder
Copy link
Contributor

#26

@sgnl05
Copy link
Owner

sgnl05 commented Nov 5, 2016

Thanks @dannygoulder !

@sgnl05 sgnl05 closed this as completed Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants