Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting messages quits after one message #103

Open
navels opened this issue Aug 16, 2024 · 2 comments · May be fixed by #104
Open

Deleting messages quits after one message #103

navels opened this issue Aug 16, 2024 · 2 comments · May be fixed by #104
Labels
bug Something isn't working

Comments

@navels
Copy link

navels commented Aug 16, 2024

This command:

slack-cleaner2 --token <my_token> --message --perform --as_user --channel <channel_name>

no longer deletes all the messages in the channel but instead just deletes the first message and quits.

I think this was broken in 9052743 probably because sleep_for is defaulting to None instead of 0.
@navels navels added the bug Something isn't working label Aug 16, 2024
navels added a commit to navels/slack_cleaner2 that referenced this issue Aug 16, 2024
@navels
fix: default rate to zero
ae595ff 
closes sgratzl#103
@navels navels linked a pull request Aug 16, 2024 that will close this issue
Open
@sgratzl
Copy link
Owner

sgratzl commented Aug 24, 2024

slack cleaner 2 is mainly designed to be used as a python module. I haven't invest too much time in the CLI client but I can take a look.

@navels
Copy link
Author

navels commented Aug 24, 2024

No worries, PR is dead simple 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default rate to zero navels/slack_cleaner2
2 participants
@navels @sgratzl