Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current master seems broken to me. #241

Closed
fbartels opened this issue Jun 24, 2015 · 4 comments
Closed

Current master seems broken to me. #241

fbartels opened this issue Jun 24, 2015 · 4 comments

Comments

@fbartels
Copy link

Hi,

I just pulled in the recent changes and then noticed that Shaarli stoppen working for me. I did not yet have the time to pinpoint the exact commit that broke it for me, but reverting back to 25c4640 (e.g. git reset --hard 25c4640) fixed it for the moment.

This is the error I have in my Apache error.log:
mod_fcgid: stderr: PHP Parse error: syntax error, unexpected '[' in /var/www/clients/client1/web35/web/application/LinkDB.php on line 306

@nodiscc
Copy link
Member

nodiscc commented Jun 25, 2015

I can't reproduce this (apache 2.4 with mod_php).

Line 306 $keys = ['title', 'description', 'url', 'tags']; looks ok to me, no missing closing brackets/quotes before it.

@fbartels can you re-clone an test again? Make sure your local copy is an exact clone of the repo. I would try with mod_fcgid but unfortunately I don't have it set up at the moment.

@fbartels
Copy link
Author

Hi @nodiscc ,

I just did a fresh checkout and walked through the commit history of the last days (Oldest first starting with 4de7144).

Starting with 38a0c25 I only get a white page and the already posted error.

php -v
PHP 5.3.3-7+squeeze26 with Suhosin-Patch (cli) (built: Apr 29 2015 18:51:11) 
Copyright (c) 1997-2009 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies
    with Suhosin v0.9.32.1, Copyright (c) 2007-2010, by SektionEins GmbH

@fbartels
Copy link
Author

Ah, found this issue and created a pull request #249 .

@nodiscc
Copy link
Member

nodiscc commented Jun 26, 2015

Thanks for the patch, see #249, #250

@nodiscc nodiscc closed this as completed Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants