Move all configuration settings to data/config.php

[nodiscc]

Once #40 is solved we can think about moving options.php out of data/. It is not program data and should not be writeable by the server.

We can also provide a options.example.php presenting all switches from https://github.com/shaarli/Shaarli/blob/master/index.php and https://github.com/shaarli/Shaarli/wiki#configuration and have evrything in one place.

See below

[nodiscc]

We currently have 2 config files: data/config.php and data/options.php

I think it would be better to get rid of config.php, and write all options/config variables in options.php. Of course options.php will then really need to be writable by the server. So if we go this way, this bug can be closed.

[e2jk]

I like the idea of combining into 1 file. I do prefer the name config rather than options.
I can't think of any at this point, but we need to be careful as to not introduce locking/race conditions/data loss, where a user manually edits the config file, an option is then changed via the website, and either the server can't commit its changes or it overwrites what the user set.

[nodiscc]

The race condition is already present when you have 2 ?do=configure tabs open at the same time. Of course the last saved file/config changes overwrites the previous. You're right that we should check for write permissions on the config file itself.

[nodiscc]

On install, all hardcoded options in index.php should also be written to data/options.php so that users have all configuration options visible when editing the file.

Then we can get rid of the need to manually create options.php (https://github.com/shaarli/Shaarli/wiki#configuration). We should update the doc when it's done.

[nodiscc]

Pull request #108 solves this

[ArthurHoaro]

It can be done easily by iterating over $GLOBALS['config']. However, I'd prefer to keep config.php instead of using options.php.