Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding get_link() method and get-link endpoint #67

Open
andreworg opened this issue Feb 23, 2023 · 1 comment
Open

adding get_link() method and get-link endpoint #67

andreworg opened this issue Feb 23, 2023 · 1 comment
Milestone

Comments

@andreworg
Copy link

Hi all

I forked the repo and added a get_link() method and get-link endpoint to fetch a single link by id:

master...andreworg:python-shaarli-client:andrew-get_link

I needed this for a project of mine (see shaarli/Shaarli#1943); I think it also serves as partial workaround for #34 (you can use get_link() to fetch all data for an existing record, then use put_link() to update the record).

I'm writing this here before submitting a PR because I have not updated the test suite yet - I'm having trouble with that - and I was wondering what to do.

Thanks

@nodiscc nodiscc self-assigned this Apr 6, 2023
@nodiscc nodiscc removed their assignment Jul 27, 2023
@nodiscc
Copy link
Member

nodiscc commented Feb 8, 2024

Hi @andreworg
I think you should submit your patch (don't forget to update the documentation)
About the tests, I think a simple copy of test_get_links_uri https://github.com/shaarli/python-shaarli-client/blob/master/tests/client/test_v1.py#L141 should be fine (just replace .get_links with .get_link)

We can start from there

@nodiscc nodiscc added this to the 0.5.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants