Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Not setting a name bug?FR? Not clear that one MUST give text buttons a name... #201

Closed
ksdavidc opened this issue Jan 18, 2024 · 2 comments · Fixed by #206
Closed

Comments

@ksdavidc
Copy link

Trying this for the first time and lost some time using the button maker because I neglected to give my text buttons (which I thought would be the easiest button to test) a name. I kept trying to create append text buttons, that were all called ""undefined" that did nothing. It took me a while to realize that I needed to give it a name. Perhaps a better error message, or a prompt to give the button a name, or a default name if none is given as with butttonID, which does not trigger same error...

Other types of buttons worked without names, e.g. a command button to pin the current file or open daily note
For some reason, probably my settings?, link buttons didn't work at all.

Other than that nice plugin and looking forward to using it...

@shabegom
Copy link
Owner

shabegom commented Feb 1, 2024

Will be fixed when #206 if merged and released

@shabegom shabegom closed this as completed Feb 1, 2024
@ksdavidc
Copy link
Author

ksdavidc commented Feb 1, 2024

Just noticed you are my scratchblocks champ! small world. I was hoping to ask you how I can upgrade/takeover that project....but I glanced somewhere at some point you are preoccupied, so I will leave it. Hope things turn out well for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants