Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Hash authentication failure with OTA enabled #98

Closed
librehat opened this issue Dec 14, 2016 · 2 comments
Closed

Hash authentication failure with OTA enabled #98

librehat opened this issue Dec 14, 2016 · 2 comments
Assignees
@librehat
Labels
bug

Comments

@librehat
Copy link
Contributor

Reproducible with using shadowsocks-libqss as client uploading files
@librehat librehat added the bug label Dec 14, 2016
@librehat librehat self-assigned this Dec 14, 2016
@librehat librehat mentioned this issue Dec 14, 2016
Closed
@librehat
Copy link
Contributor Author

librehat commented Dec 14, 2016 •
edited
Loading

This doesn't happen while using shadowsocks-libqss as server but other implementation as client. I've added some new test cases, which shows that addChunkAuth and verifyExtractChunkAuth are OK.

@librehat
Copy link
Contributor Author

Found the problem.
So when the client received the maximum data chunk (65536) and pack it with OTA auth code, the datagram becomes as big as 65548 (with 10 + 2 more bytes). Since it exceeds the maximum size, the server won't load the rest 12 bytes and will then consider then as auth code!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@librehat librehat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@librehat