Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TTML generator timestamp millisecond formatting #1179

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: TTML generator timestamp millisecond formatting #1179

merged 1 commit into from
Jul 5, 2023

Conversation

marcusspangenberg
Copy link
Contributor

@marcusspangenberg marcusspangenberg commented Mar 6, 2023 •
edited
Loading

Fix bug where milliseconds were formatted with two digits instead of three, resulting in incorrect timestamps in TTML cues.

Fixes #1180

@marcusspangenberg
fix: TTML generator timestamp millisecond formatting
9a94ffb 
Fix bug where milliseconds were formatted with two digits instead of
three, resuling in incorrect timestamps in TTML cues.
@google-cla
Copy link

google-cla bot commented Mar 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marcusspangenberg marcusspangenberg mentioned this pull request Mar 6, 2023
Closed
@joeyparrish joeyparrish merged commit 494769c into shaka-project:main Jul 5, 2023
@sr1990 sr1990 mentioned this pull request Jul 8, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Jul 12, 2023
@sr1990
fix: Update golden files for ttml tests and failing hls unit tests. (#…
ac47e52 
…1226)

Updating golden files for failing ttml tests in packager_test.py related
to #1179 and
failing HLS unit tests related to
#1170.
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TTML generator millisecond formatting uses two digits
2 participants
@marcusspangenberg @joeyparrish