Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EME manager repeats first config instead of testing all configs #177

Closed
joeyparrish opened this issue Sep 9, 2015 · 0 comments
Closed

EME manager repeats first config instead of testing all configs #177

joeyparrish opened this issue Sep 9, 2015 · 0 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.5.0

Comments

@joeyparrish
Copy link
Member

If there are multiple key systems specified with multiple configs, the EME manager queries the first config repeatedly. This is due to a bug in buildKeySystemPromiseChain_ where a closure inside a loop captures references instead of values.

This bug has existed since v1.2.0. The code was introduced in b092231 and moved in 66d760e.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Sep 9, 2015
@joeyparrish joeyparrish self-assigned this Sep 9, 2015
@joeyparrish joeyparrish added this to the v1.5.0 milestone Sep 9, 2015
@joeyparrish joeyparrish mentioned this issue Sep 9, 2015
Merged
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot