-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow menus cover control panel elements #3217
Comments
Hello @prophet-x , thank you for your suggestions! We'd love to see a PR for the enhancements. |
sure sir, working on it |
@prophet-x How are you getting extra features in the overflow menu that is "resolution", "language" and "playback speed"? |
@sradhanjan I have used the shaka-player from the shaka ui library which has all these controls in overflow menu and they can be configured, you'll find more help in the tutorial docs about the shaka ui library and how to configure it. |
hey can I work on this issue please |
hi @prakhartech I have been assigned this issue and I'm working on this issue, you can find other open issues to contribute. |
Hello @prophet-x! Are you still working on a fix for this issue? Please let me know if you need any help approaching the solution and I will be happy to help! (Edit: Removed a paragraph of solutions that where implemented on the pull request!) |
Have you read the FAQ and checked for duplicate open issues?
YES
Is your feature request related to a problem? Please describe.
NO, I would like to suggest some Video player UI improvements.
Describe the solution you'd like
I want to suggest some UI improvement for the player:
The range element is a special input element so it might be better if the cursor changes to pointer when it hovers over any range input element.
![range track element](https://user-images.githubusercontent.com/57630117/111035508-ea620d80-8440-11eb-9199-c7b9e2b876e1.jpeg)
The overflow menu overlaps the control buttons (volume, language, etc.) especially in full screen mode so I would
![OVERFLOW MENU](https://user-images.githubusercontent.com/57630117/111035557-1aa9ac00-8441-11eb-8cc2-75acf3171cea.png)
suggest to shift the overflow menu a little bit upwards so it doesn't overlaps over the control buttons.
Both the suggestions can be implemented by minor changes to the .track() and .shaka-overflow-menu in the CSS.
Describe alternatives you've considered
Alternative solution would be to create own CSS file for each project to make these changes or use the browser built-in video player.
Additional context
I'm a Engineering student from India and want to apply to GSOC'21 through this organization, I've gone through the codebase and want to contribute to this amazing organization.
This will be my first PR in this organization, So please give a feedback on whether I should create a PR for the suggested improvements.
The text was updated successfully, but these errors were encountered: