Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow menus cover control panel elements #3217

Open
kamalmulani opened this issue Mar 13, 2021 · 7 comments
Open

Overflow menus cover control panel elements #3217

kamalmulani opened this issue Mar 13, 2021 · 7 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Milestone

Comments

@kamalmulani
Copy link

Have you read the FAQ and checked for duplicate open issues?
YES

Is your feature request related to a problem? Please describe.
NO, I would like to suggest some Video player UI improvements.

Describe the solution you'd like

I want to suggest some UI improvement for the player:

  1. The range element is a special input element so it might be better if the cursor changes to pointer when it hovers over any range input element.
    range track element

  2. The overflow menu overlaps the control buttons (volume, language, etc.) especially in full screen mode so I would
    suggest to shift the overflow menu a little bit upwards so it doesn't overlaps over the control buttons.
    OVERFLOW MENU

Both the suggestions can be implemented by minor changes to the .track() and .shaka-overflow-menu in the CSS.

Describe alternatives you've considered

Alternative solution would be to create own CSS file for each project to make these changes or use the browser built-in video player.

Additional context

I'm a Engineering student from India and want to apply to GSOC'21 through this organization, I've gone through the codebase and want to contribute to this amazing organization.
This will be my first PR in this organization, So please give a feedback on whether I should create a PR for the suggested improvements.

@michellezhuogg
Copy link
Contributor

Hello @prophet-x , thank you for your suggestions! We'd love to see a PR for the enhancements.
Please test with different browsers different video container sizes for the css changes. Thanks!

@michellezhuogg michellezhuogg added type: enhancement New feature or request gsoc component: UI The issue involves the Shaka Player UI and removed needs triage labels Mar 13, 2021
@kamalmulani
Copy link
Author

sure sir, working on it

@shaka-bot shaka-bot added this to the Backlog milestone Mar 13, 2021
@sradhanjan
Copy link

@prophet-x How are you getting extra features in the overflow menu that is "resolution", "language" and "playback speed"?

(this is what I am getting to see)
image

@kamalmulani
Copy link
Author

kamalmulani commented Mar 14, 2021

@sradhanjan I have used the shaka-player from the shaka ui library which has all these controls in overflow menu and they can be configured, you'll find more help in the tutorial docs about the shaka ui library and how to configure it.

@prakhartech
Copy link

hey can I work on this issue please

@kamalmulani
Copy link
Author

kamalmulani commented Mar 22, 2021

hey can I work on this issue please

hi @prakhartech I have been assigned this issue and I'm working on this issue, you can find other open issues to contribute.

@michellezhuogg michellezhuogg added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this and removed gsoc labels Mar 22, 2021
@joeyparrish joeyparrish changed the title Minor UI Improvement Overflow menus cover control panel elements Mar 30, 2021
@nbcl
Copy link
Contributor

nbcl commented Apr 5, 2021

Hello @prophet-x!

Are you still working on a fix for this issue?

Please let me know if you need any help approaching the solution and I will be happy to help!

(Edit: Removed a paragraph of solutions that where implemented on the pull request!)

@TheModMaker TheModMaker added the priority: P2 Smaller impact or easy workaround label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants