Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles coming in reverse order #3762

Closed
prashant-hotstar opened this issue Nov 18, 2021 · 5 comments
Closed

Subtitles coming in reverse order #3762

prashant-hotstar opened this issue Nov 18, 2021 · 5 comments
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@prashant-hotstar
Copy link

prashant-hotstar commented Nov 18, 2021

Have you read the FAQ and checked for duplicate open issues?

What version of Shaka Player are you using?
Latest 3.3.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
demo app

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

What did you do?

  1. Play the content on demo app
  2. Inject the attached vet file on any content on demo app

subtitle.vtt.zip

What did you expect to happen?

  1. Subtitle line which contains 'end' should be coming in bottom

What actually happened?

  1. Subtitle line which contains 'end' is coming at top
@prashant-hotstar prashant-hotstar added the type: bug Something isn't working correctly label Nov 18, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Nov 18, 2021
@theodab
Copy link
Contributor

theodab commented Jan 18, 2022

Chromium does not support the lineAlign or positionAlign attributes. See: https://bugs.chromium.org/p/chromium/issues/detail?id=633690

@theodab theodab added browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) component: captions/subtitles The issue involves captions or subtitles type: external An issue with an external dependency; not our issue; sometimes kept open for tracking labels Jan 18, 2022
@avelad
Copy link
Member

avelad commented Jan 18, 2022

@theodab Demo app uses a UITextDisplayer… so the browser is not involved in the rendering.

@joeyparrish
Copy link
Member

@prashant-hotstar, can you please confirm what version of Shaka Player you are using? v3.3.0 was only released on January 7, 2022, but your issue was posted on November 18, 2021.

Were you using a pre-release version from the master branch at that time? If so, can you please try again with the official v3.3.0 release?

@joeyparrish joeyparrish added status: waiting on response Waiting on a response from the reporter(s) of the issue and removed type: external An issue with an external dependency; not our issue; sometimes kept open for tracking browser: Chrome Issues affecting Chrome or Chromium derivatives (except Edge) labels Jan 18, 2022
@avelad
Copy link
Member

avelad commented Jan 18, 2022

I tested this morning with the attached vtt file and it happens with the master branch

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jan 18, 2022
@TheModMaker TheModMaker added the priority: P1 Big impact or workaround impractical; resolve before feature release label Jan 21, 2022
@avelad avelad modified the milestones: v3.3, v4.1 May 4, 2022
@avelad avelad modified the milestones: v4.1, v4.2 Jun 3, 2022
@avelad avelad modified the milestones: v4.2, v4.3 Aug 17, 2022
@avelad avelad modified the milestones: v4.3, v4.4 Nov 11, 2022
@avelad
Copy link
Member

avelad commented Aug 18, 2023

Tested in the main branch and now it works as expected

@avelad avelad closed this as completed Aug 18, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 17, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

6 participants