element.getAttribute is not a function error in v2 beta3

[mlondon1]

Hi,
I am seeing the following error in Shaka player v2.0.0-beta3 that I do not see in beta2 when attempting to play my Widevine-Dash VOD content in Google Chrome

streaming_engine.js:1148 (text:3) failed fetch and append: code=undefined(anonymous function) @ streaming_engine.js:1148
player.js:1614 Assertion failed: Wrong error type!shaka.Player.onError_ @ player.js:1614(anonymous function) @ streaming_engine.js:1149
main.js:182 Player error TypeError: element.getAttribute is not a function(…)

[joeyparrish]

Can you please provide a manifest URL with which I could reproduce this error?

[joeyparrish]

@mlondon1, we cannot reproduce. Can you provide a manifest URL that reproduces the error?

[mlondon1]

Hi, This is encrypted premium content, is there anything else that I can provide? Or do you not need to play the content and just want to look at the MPD?

[joeyparrish]

We need some way to reproduce your issue before we can solve it. Can you provide instructions on how to reproduce the issue?

Usually, a good repro involves a manifest URL and license server URL that can be used in the demo app. If you can't provide those things publicly, you can always send me a private email with the details. My email address can be found in CONTRIBUTORS.

[joeyparrish]

Thanks for the manifest info. I've tracked the bug down to here:

shaka.media.TtmlTextParser.getInheritedAttribute_ = function(
    element, attributeName) {
  var ret = null;
  while (element) {
    ret = element.getAttribute(attributeName);

Now that we have repro, it should be easy to fix. Thanks!

[mlondon1]

You're welcome

[joeyparrish]

@mlondon1, please try again with the latest from master and let us know if you have any issues.