feat: Add config for add headers to license requests

[avelad]

No description provided.

[avelad]

I need review the error: Invalid config, unrecognized key .drm.advanced.com.widevine.alpha.headers.X-AxDRM-Message in the demo

[shaka-bot]

Incremental code coverage: 91.30%

[joeyparrish]

Looks good to me, apart from those leftover console.log statements and any errors you're seeing in the demo

[avelad]

I need review the error: Invalid config, unrecognized key .drm.advanced.com.widevine.alpha.headers.X-AxDRM-Message in the demo

@joeyparrish can you help me to resolve it?

[joeyparrish]

I need review the error: Invalid config, unrecognized key .drm.advanced.com.widevine.alpha.headers.X-AxDRM-Message in the demo

@joeyparrish can you help me to resolve it?

I found the source of the problem. It's really a design problem.

The configuration system wants to map out and type-check every input. However, some parts of the config are dictionaries with arbitrary keys. Ex: drm.advanced[keySystem]...

We still want to type-check the values under those arbitrary keys, so the config system has this "overrides" system. It basically allows the config algorithm to skip a level in the hierarchy. A simplified example:

    const overrides = {
      '.drm.servers': '',
      '.drm.advanced': {
        videoRobustness: '',
        audioRobustness: '',
        sessionType: '',
      },
    };

This means the path .drm.servers is a dictionary with arbitrary keys, and the values are strings. So .drm.servers[keySystem] should always be a string, if present.

And the path .drm.advanced is a dictionary with arbitrary keys, and the values are these more complex objects with videoRobustness, audioRobustness, and sessionType. So .drm.advanced[keySystem] should always be one such object, if present.

The trouble is that headers is a second layer of a dictionary with arbitrary keys, and the hacky system I described above isn't designed to handle that. Ex:

    const overrides = {
      '.drm.advanced': {
        videoRobustness: '',
        audioRobustness: '',
        sessionType: '',
        headers: {},
      },
    };

Now .drm.advanced[keySystem].headers is an object, which is fine. But we don't have any "valid" keys in that object if you go deeper.

I'm pondering the "best" solution, where "best" either means "cleanest", "most extensible", or "quickest"...

[joeyparrish]

I'm pondering the "best" solution, where "best" either means "cleanest", "most extensible", or "quickest"...

I found a relatively quick solution... the merge system will now recognize "{}" in the template as "just an object, do a shallow copy and don't recurse"

[joeyparrish]

@avelad, please check the demo and confirm, then merge when you're ready.

[avelad]

Yes it works, but now the tests are failing

[joeyparrish]

This is not right. overrides always has keys (eg ".drm.advanced"), and I don't see why you would check it here.

[avelad]

It’s the only solution that I found to fix the tests