fix: Fix unlinking existing binaries #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We failed to unlink binaries because we checked for the existence of
"path" instead of the correct variable name "outputPath". This went
unnoticed because "path" is a global referring to the "path" module,
so the code still ran.
Another factor that made this more difficult to notice is that in
other methods, we clobbered the global module "path" with a method
parameter of the same name. This has also been fixed by renaming
method parameters from "path" to something else.