fix: Choose platform-specific msedgedriver version #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Edge pushes out a new stable release, the latest driver version may actually vary between platforms. This modifies the driver version logic for Edge to pull a platform-specific file to determine what the latest version is for that specific platform.
theodab
approved these changes
Feb 11, 2022
joeyparrish
referenced
this pull request
in shaka-project/karma-local-wd-launcher
Feb 11, 2022
joeyparrish
referenced
this pull request
in shaka-project/karma-local-wd-launcher
Feb 11, 2022
joeyparrish
referenced
this pull request
in shaka-project/shaka-player
Feb 11, 2022
joeyparrish
referenced
this pull request
in shaka-project/shaka-player
Feb 16, 2022
joeyparrish
referenced
this pull request
in shaka-project/shaka-player
Feb 16, 2022
joeyparrish
referenced
this pull request
in shaka-project/shaka-player
Feb 16, 2022
joeyparrish
referenced
this pull request
in shaka-project/shaka-player
Feb 16, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Edge pushes out a new stable release, the latest driver version
may actually vary between platforms. This modifies the driver version
logic for Edge to pull a platform-specific file to determine what the
latest version is for that specific platform.