Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should eslint-xxx be peerDependencies? #267

Closed
vjpr opened this issue Feb 21, 2017 · 3 comments
Closed

Should eslint-xxx be peerDependencies? #267

vjpr opened this issue Feb 21, 2017 · 3 comments
Labels

Comments

@vjpr
Copy link

vjpr commented Feb 21, 2017

npm install
...
WARN registry.npmjs.org/bootstrap-loader/2.0.0-beta.21 requires a peer of eslint-plugin-jsx-a11y@^2.2.3 but none was installed.
WARN registry.npmjs.org/bootstrap-loader/2.0.0-beta.21 requires a peer of eslint-plugin-react@^6.6.0 but none was installed.

Wouldn't they just be for development - so devDependencies?

@justin808
Copy link
Member

@vjpr you're 100% right!

@Judahmeek Any idea how this snuck in?

@vjpr These should be devDependencies.

Anybody want to do a PR?

@justin808 justin808 added the bug label Feb 21, 2017
@Judahmeek
Copy link
Contributor

Those two packages are peer dependencies of bootstrap-loader so you're going to get that warning anyway.

@justin808
Copy link
Member

@Judahmeek They probably shouldn't be. There's no for linting to be a peer dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants