Skip to content

Commit 585b5ca

Browse files
justin808claude
andcommitted
Remove net-pop GitHub workaround for Ruby 3.4.6
The net-pop dependency issue was specific to Ruby 3.3.3 and was fixed in Ruby 3.3.4. Ruby 3.4.6 includes the fix, so the GitHub workaround is no longer needed. Using the standard gem from RubyGems. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c39d179 commit 585b5ca

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

Gemfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,8 @@ gem "autoprefixer-rails"
4545

4646
gem "awesome_print"
4747

48-
# Needed until Ruby 3.4.6 is released https://github.com/ruby/ruby/pull/11006
49-
# Related issue: https://github.com/ruby/net-pop/issues/26
50-
# TODO: When Ruby 3.4.6 is released, upgrade Ruby and remove this line
51-
gem "net-pop", github: "ruby/net-pop"
48+
# net-pop is bundled with Ruby 3.4.6 with the dependency issues fixed
49+
# The GitHub workaround from Ruby 3.3.3 is no longer needed
5250

5351
gem "redcarpet"
5452

Gemfile.lock

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
GIT
2-
remote: https://github.com/ruby/net-pop.git
3-
revision: e8d0afe2773b9eb6a23c39e9e437f6fc0fc7c733
4-
specs:
5-
net-pop (0.1.2)
6-
net-protocol
7-
81
GEM
92
remote: https://rubygems.org/
103
specs:
@@ -193,6 +186,8 @@ GEM
193186
net-imap (0.5.10)
194187
date
195188
net-protocol
189+
net-pop (0.1.2)
190+
net-protocol
196191
net-protocol (0.2.2)
197192
timeout
198193
net-smtp (0.5.1)
@@ -474,7 +469,6 @@ DEPENDENCIES
474469
jbuilder
475470
launchy
476471
listen
477-
net-pop!
478472
pg
479473
pry
480474
pry-byebug

0 commit comments

Comments
 (0)