fix: move JavaScript pack tags to head element to resolve Turbo warning

justin808 · justin808 · commit 76f0fee140ff · 2025-09-27T16:38:35.000-10:00
- Move stylesheet_pack_tag and javascript_pack_tag to head element
- Prevents Turbo warning about scripts being loaded from body
- Scripts are still deferred to maintain performance
- Fixes browser console warning about script evaluation on page changes
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -9,6 +9,9 @@
   <%= append_javascript_pack_tag('stimulus-bundle') %>
   <%= append_javascript_pack_tag('stores-registration') %>
 
+  <%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
+  <%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
+
   <%= csrf_meta_tags %>
 </head>
 <body class="min-h-screen flex flex-col bg-sky-50 text-gray-700">
@@ -20,9 +23,6 @@
 
   <%= react_component "Footer" %>
 
-  <%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
-  <%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
-
   <!-- This is a placeholder for ReactOnRails to know where to render the store props for
       client side hydration -->
   <%= redux_store_hydration_data %>
diff --git a/app/views/layouts/stimulus_layout.html.erb b/app/views/layouts/stimulus_layout.html.erb
@@ -9,6 +9,9 @@
 
   <%= append_stylesheet_pack_tag('stimulus-bundle') %>
   <%= append_javascript_pack_tag('stimulus-bundle') %>
+  
+  <%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
+  <%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
 </head>
 <body class="min-h-screen flex flex-col bg-sky-50 text-gray-700">
   <%= react_component "NavigationBarApp" %>
@@ -18,8 +21,5 @@
   </div>
 
   <%= react_component "Footer" %>
-
-  <%= stylesheet_pack_tag(media: 'all', 'data-turbolinks-track': true) %>
-  <%= javascript_pack_tag('data-turbolinks-track': true, defer: true) %>
 </body>
 </html>
diff --git a/pr-review-command.md b/pr-review-command.md
@@ -0,0 +1,34 @@
+# Claude PR Review Command
+
+Add this to your ~/.claude/CLAUDE.md file:
+
+## PR Review Command
+
+When asked to review a PR, perform a comprehensive review following these steps:
+
+1. **Fetch PR Details**: Use `gh pr view <PR_NUMBER> --json title,body,state,commits,files,additions,deletions,changedFiles`
+
+2. **Analyze Changes**: 
+   - Review the diff with `gh pr diff <PR_NUMBER>`
+   - Check for breaking changes
+   - Verify consistency with existing code patterns
+   - Check for security issues
+   - Review test coverage
+
+3. **Provide Structured Review**:
+   - **Summary**: Brief overview of changes
+   - **Strengths**: What's done well
+   - **Concerns**: Potential issues or risks
+   - **Breaking Changes**: Any backwards compatibility issues
+   - **Security**: Any security considerations
+   - **Performance**: Performance implications
+   - **Code Quality**: Style, patterns, best practices
+   - **Testing**: Test coverage and quality
+   - **Documentation**: Are changes documented?
+   - **Suggestions**: Specific improvements
+   - **Risk Level**: Low/Medium/High
+   - **Recommendation**: Approve/Request Changes/Needs Discussion
+
+4. **Check CI Status**: `gh pr checks <PR_NUMBER>`
+
+5. **Review Comments**: Check existing review comments if any
