-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to make mobile responsive #402
Comments
I'd be interested in taking a crack at it. |
That would be awesome. I'll mark you as the owner of this. I look forward to seeing your PR. |
@tfantina you only get 1 week to be the owner and show progress. |
@justin808 Hey I haven't done anything with webpacker_lite, every time I try to launch the local server I get this error:
I'm not sure what sort of additional configuration is needed in the yml file, I've also installed the webpack-manifest-plugin but I'm not sure how to proceed, although I am still really interested in this and I think I can make the example responsive I don't have a lot of experience with react_on_rails or webpacker_lite. |
I've been messing with this for several days and I just can't get it working. I will continue to do so when I have more time if not for this for my own curiosity but for the time being, I'm very sorry, I don't think I'll be able to give the pull request in time. |
@tfantina rebase on top of master...I've updated to React on Rails 9.0. |
@justin808, I built a responsive app on top of a forked version of this tutorial. It has gotten a little behind this repo, it isn't using Webpacker yet, and I have been waiting to update it, hoping to hold onto hot reloading : ). It uses flexbox and media queries, with some site-wide SCSS mixins handling the responsiveness to keep things dry. It wasn't easy to build, since I had to remove Bootstrap to get responsive flexbox to work. It is really a different app with its own If you think it would be a good idea, this approach could be applied to make your app responsive. It could be rolled in as a "no-Bootstrap" branch (assuming it is impossible to make flexbox work properly with Bootstrap in place). |
@reconstructions I'm open to considering this! |
@reconstructions Please send me an email justin@shakacode.com. |
I m willing to take this on! |
@justin808 I will take care this issue. Since this is using bootstrap, it seems like it is already responsive. Do you have any special design? Or if I make this app look good, is it ok? |
If this issue is still available, I would like to grab it as part of my application process. |
@justin808 I have the fix for this from my own project, can I take this issue? |
@KnoxMajor that would be awesome! Sorry for the slow reply! |
right on, @justin808 I'll take it |
This project is responsive now. |
We need to make this example mobile responsive.
Any takers?
The text was updated successfully, but these errors were encountered: