Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make mobile responsive #402

Closed
justin808 opened this issue Jun 24, 2017 · 16 comments
Closed

Need to make mobile responsive #402

justin808 opened this issue Jun 24, 2017 · 16 comments

Comments

@justin808
Copy link
Member

We need to make this example mobile responsive.

Any takers?

@tfantina
Copy link

tfantina commented Sep 1, 2017

I'd be interested in taking a crack at it.

@justin808
Copy link
Member Author

That would be awesome. I'll mark you as the owner of this. I look forward to seeing your PR.

@justin808
Copy link
Member Author

@tfantina you only get 1 week to be the owner and show progress.

@tfantina
Copy link

tfantina commented Sep 4, 2017

@justin808 Hey I haven't done anything with webpacker_lite, every time I try to launch the local server I get this error:

WebpackerLite can't find the manifest file: /path/react-webpack-rails-tutorial/public/webpack/development/manifest.json
        Possible causes:
          1. You have not invoked webpack.
          2. You have misconfigured WebpackerLite's config/webpacker_lite.yml file.
          3. Your Webpack configuration is not creating a manifest.

I'm not sure what sort of additional configuration is needed in the yml file, I've also installed the webpack-manifest-plugin but I'm not sure how to proceed, although I am still really interested in this and I think I can make the example responsive I don't have a lot of experience with react_on_rails or webpacker_lite.

@tfantina
Copy link

tfantina commented Sep 8, 2017

I've been messing with this for several days and I just can't get it working. I will continue to do so when I have more time if not for this for my own curiosity but for the time being, I'm very sorry, I don't think I'll be able to give the pull request in time.

@justin808
Copy link
Member Author

@tfantina rebase on top of master...I've updated to React on Rails 9.0.

@reconstructions
Copy link
Contributor

@justin808, I built a responsive app on top of a forked version of this tutorial. It has gotten a little behind this repo, it isn't using Webpacker yet, and I have been waiting to update it, hoping to hold onto hot reloading : ).

It uses flexbox and media queries, with some site-wide SCSS mixins handling the responsiveness to keep things dry. It wasn't easy to build, since I had to remove Bootstrap to get responsive flexbox to work.

It is really a different app with its own client/app/bundles, but a lot heavier on design, typography, svg graphics, and that kind of thing.

If you think it would be a good idea, this approach could be applied to make your app responsive. It could be rolled in as a "no-Bootstrap" branch (assuming it is impossible to make flexbox work properly with Bootstrap in place).

@justin808
Copy link
Member Author

@reconstructions I'm open to considering this!

@justin808
Copy link
Member Author

@reconstructions Please send me an email justin@shakacode.com.

@mradeybee
Copy link

I m willing to take this on!

@dreamsoftech
Copy link

@justin808 I will take care this issue. Since this is using bootstrap, it seems like it is already responsive. Do you have any special design? Or if I make this app look good, is it ok?

@Trip4077
Copy link

If this issue is still available, I would like to grab it as part of my application process.

@KnoxMajor
Copy link

@justin808 I have the fix for this from my own project, can I take this issue?

@justin808
Copy link
Member Author

@KnoxMajor that would be awesome! Sorry for the slow reply!

@KnoxMajor
Copy link

right on, @justin808 I'll take it

@ahangarha
Copy link
Contributor

This project is responsive now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants