tmp

Author: AbanoubGhadban

react_on_rails_pro/packages/node-renderer/tests/helper.ts

@@ -58,11 +58,23 @@ export function vmSecondaryBundlePath(testName: string) {
 }
 
 export async function createVmBundle(testName: string) {
+  // Build config with module support before creating VM bundle
+  buildConfig({
+    bundlePath: bundlePath(testName),
+    supportModules: true,
+    stubTimers: false,
+  });
   await safeCopyFileAsync(getFixtureBundle(), vmBundlePath(testName));
   await buildExecutionContext([vmBundlePath(testName)], /* buildVmsIfNeeded */ true);
 }
 
 export async function createSecondaryVmBundle(testName: string) {
+  // Build config with module support before creating VM bundle
+  buildConfig({
+    bundlePath: bundlePath(testName),
+    supportModules: true,
+    stubTimers: false,
+  });
   await safeCopyFileAsync(getFixtureSecondaryBundle(), vmSecondaryBundlePath(testName));
   await buildExecutionContext([vmSecondaryBundlePath(testName)], /* buildVmsIfNeeded */ true);
 }

react_on_rails_pro/packages/node-renderer/tests/worker.test.ts

@@ -30,6 +30,15 @@ const { protocolVersion } = packageJson;
 
 disableHttp2();
 
+// Helper to create worker with standard options
+const createWorker = (options: Parameters<typeof worker>[0] = {}) =>
+  worker({
+    bundlePath: bundlePathForTest(),
+    supportModules: true,
+    stubTimers: false,
+    ...options,
+  });
+
 describe('worker', () => {
   beforeEach(async () => {
     await resetForTest(testName);
@@ -40,9 +49,7 @@ describe('worker', () => {
   });
 
   test('POST /bundles/:bundleTimestamp/render/:renderRequestDigest when bundle is provided and did not yet exist', async () => {
-    const app = worker({
-      bundlePath: bundlePathForTest(),
-    });
+    const app = createWorker();
 
     const form = formAutoContent({
       gemVersion,
@@ -67,9 +74,7 @@ describe('worker', () => {
   });
 
   test('POST /bundles/:bundleTimestamp/render/:renderRequestDigest', async () => {
-    const app = worker({
-      bundlePath: bundlePathForTest(),
-    });
+    const app = createWorker();
 
     const form = formAutoContent({
       gemVersion,
@@ -102,8 +107,7 @@ describe('worker', () => {
     async () => {
       await createVmBundleForTest();
 
-      const app = worker({
-        bundlePath: bundlePathForTest(),
+      const app = createWorker({
         password: 'password',
       });
 
@@ -128,8 +132,7 @@ describe('worker', () => {
     async () => {
       await createVmBundleForTest();
 
-      const app = worker({
-        bundlePath: bundlePathForTest(),
+      const app = createWorker({
         password: 'password',
       });
 
@@ -154,8 +157,7 @@ describe('worker', () => {
     async () => {
       await createVmBundleForTest();
 
-      const app = worker({
-        bundlePath: bundlePathForTest(),
+      const app = createWorker({
         password: 'my_password',
       });
 
@@ -181,9 +183,7 @@ describe('worker', () => {
     async () => {
       await createVmBundleForTest();
 
-      const app = worker({
-        bundlePath: bundlePathForTest(),
-      });
+      const app = createWorker();
 
       const res = await app
         .inject()
@@ -204,8 +204,7 @@ describe('worker', () => {
     const bundleHash = 'some-bundle-hash';
     await createAsset(testName, bundleHash);
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -230,8 +229,7 @@ describe('worker', () => {
     const bundleHash = 'some-bundle-hash';
     await createAsset(testName, bundleHash);
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -254,8 +252,7 @@ describe('worker', () => {
 
   test('post /asset-exists requires targetBundles (protocol version 2.0.0)', async () => {
     await createAsset(testName, String(BUNDLE_TIMESTAMP));
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -276,8 +273,7 @@ describe('worker', () => {
   test('post /upload-assets', async () => {
     const bundleHash = 'some-bundle-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -299,8 +295,7 @@ describe('worker', () => {
     const bundleHash = 'some-bundle-hash';
     const bundleHashOther = 'some-other-bundle-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -325,8 +320,7 @@ describe('worker', () => {
     const bundleHash = 'some-bundle-hash';
     const secondaryBundleHash = 'secondary-bundle-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -380,8 +374,7 @@ describe('worker', () => {
   test('post /upload-assets with only bundles (no assets)', async () => {
     const bundleHash = 'bundle-only-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -416,8 +409,7 @@ describe('worker', () => {
   test('post /upload-assets with no assets and no bundles (empty request)', async () => {
     const bundleHash = 'empty-request-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -444,8 +436,7 @@ describe('worker', () => {
   test('post /upload-assets with duplicate bundle hash silently skips overwrite and returns 200', async () => {
     const bundleHash = 'duplicate-bundle-hash';
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -520,16 +511,15 @@ describe('worker', () => {
     expect(files).toHaveLength(1);
     expect(files[0]).toBe(`${bundleHash}.js`);
 
-    // Verify the original content is preserved (62 bytes from bundle.js, not 84 from secondary-bundle.js)
-    expect(secondBundleSize).toBe(62); // Size of getFixtureBundle(), not getFixtureSecondaryBundle()
+    // Verify the original content is preserved (1646 bytes from bundle.js, not 1689 from secondary-bundle.js)
+    expect(secondBundleSize).toBe(1646); // Size of getFixtureBundle(), not getFixtureSecondaryBundle()
   });
 
   test('post /upload-assets with bundles placed in their own hash directories, not targetBundles directories', async () => {
     const bundleHash = 'actual-bundle-hash';
     const targetBundleHash = 'target-bundle-hash'; // Different from actual bundle hash
 
-    const app = worker({
-      bundlePath: bundlePathForTest(),
+    const app = createWorker({
       password: 'my_password',
     });
 
@@ -574,8 +564,7 @@ describe('worker', () => {
   describe('incremental render endpoint', () => {
     // Helper functions to reduce code duplication
     const createWorkerApp = (password = 'my_password') =>
-      worker({
-        bundlePath: bundlePathForTest(),
+      createWorker({
         password,
       });