ci: correct rubocop offenses

Author: ihabadham

lib/generators/react_on_rails/bin/dev

@@ -10,11 +10,11 @@ end
 def generate_packs
   puts "Generating React on Rails packs..."
   system "bundle exec rake react_on_rails:generate_packs"
-  
-  unless $?.success?
-    puts "Pack generation failed"
-    exit 1
-  end
+
+  return if $CHILD_STATUS.success?
+
+  puts "Pack generation failed"
+  exit 1
 end
 
 def run_production_like
@@ -27,22 +27,22 @@ def run_production_like
   puts ""
   puts "Access at: http://localhost:3001"
   puts ""
-  
+
   # Generate React on Rails packs first
   generate_packs
-  
+
   # Precompile assets in production mode
   puts "Precompiling assets..."
   system "RAILS_ENV=production NODE_ENV=production bundle exec rails assets:precompile"
-  
-  if $?.success?
+
+  if $CHILD_STATUS.success?
     puts "Assets precompiled successfully"
     puts "Starting Rails server in production mode..."
     puts ""
     puts "Press Ctrl+C to stop the server"
     puts "To clean up: rm -rf public/packs && bin/dev"
     puts ""
-    
+
     # Start Rails in production mode
     system "RAILS_ENV=production bundle exec rails server -p 3001"
   else
@@ -61,10 +61,10 @@ def run_static_development
   puts ""
   puts "Access at: http://localhost:3000"
   puts ""
-  
+
   # Generate React on Rails packs first
   generate_packs
-  
+
   if installed? "overmind"
     system "overmind start -f Procfile.dev-static"
   elsif installed? "foreman"
@@ -86,7 +86,7 @@ end
 
 def run_development(process)
   generate_packs
-  
+
   system "#{process} start -f Procfile.dev"
 rescue Errno::ENOENT
   warn <<~MSG
@@ -104,30 +104,30 @@ elsif ARGV[0] == "static"
 elsif ARGV[0] == "help" || ARGV[0] == "--help" || ARGV[0] == "-h"
   puts <<~HELP
     Usage: bin/dev [command]
-    
+
     Commands:
       (none) / hmr        Start development server with HMR (default)
       static              Start development server with static assets (no HMR, no FOUC)
       production-assets   Start with production-optimized assets (no HMR)
       prod                Alias for production-assets
       help                Show this help message
-      
+    #{'  '}
     HMR Development mode (default):
     - Hot Module Replacement (HMR) enabled
     - Automatic React on Rails pack generation
     - Source maps for debugging
     - May have Flash of Unstyled Content (FOUC)
     - Fast recompilation
     - Access at: http://localhost:3000
-    
+
     Static development mode:
     - No HMR (static assets with auto-recompilation)
     - Automatic React on Rails pack generation
     - CSS extracted to separate files (no FOUC)
     - Development environment (faster builds than production)
     - Source maps for debugging
     - Access at: http://localhost:3000
-    
+
     Production-like mode:
     - Automatic React on Rails pack generation
     - Optimized, minified bundles

lib/generators/react_on_rails/install_generator.rb

@@ -102,10 +102,11 @@ def ensure_shakapacker_installed
         return if shakapacker_installed?
 
         GeneratorMessages.add_info("Shakapacker not detected. Installing Shakapacker...")
-        
+
         result = system("rails shakapacker:install")
         unless result
-          GeneratorMessages.add_error("Failed to install Shakapacker automatically. Please run 'rails shakapacker:install' manually.")
+          GeneratorMessages.add_error("Failed to install Shakapacker automatically. " \
+                                      "Please run 'rails shakapacker:install' manually.")
           return
         end
 

spec/react_on_rails/binstubs/dev_spec.rb

@@ -20,7 +20,8 @@ def setup_script_execution
     # Mock ARGV to simulate no arguments (default HMR mode)
     stub_const("ARGV", [])
     # Mock pack generation
-    allow_any_instance_of(Kernel).to receive(:system).with("bundle exec rake react_on_rails:generate_packs").and_return(true)
+    allow_any_instance_of(Kernel).to receive(:system)
+      .with("bundle exec rake react_on_rails:generate_packs").and_return(true)
   end
 
   it "includes pack generation function" do
@@ -51,7 +52,7 @@ def setup_script_execution
   it "with Overmind installed, uses Overmind" do
     setup_script_execution
     allow(IO).to receive(:popen).with("overmind -v").and_return("Some truthy result")
-    expect_any_instance_of(Kernel).to receive(:system).with("overmind start -f Procfile.dev").and_return(true)
+    expect_any_instance_of(Kernel).to receive(:system).with("overmind start -f Procfile.dev")
 
     load script_path
   end
@@ -60,7 +61,7 @@ def setup_script_execution
     setup_script_execution
     allow(IO).to receive(:popen).with("overmind -v").and_raise(Errno::ENOENT)
     allow(IO).to receive(:popen).with("foreman -v").and_return("Some truthy result")
-    expect_any_instance_of(Kernel).to receive(:system).with("foreman start -f Procfile.dev").and_return(true)
+    expect_any_instance_of(Kernel).to receive(:system).with("foreman start -f Procfile.dev")
 
     load script_path
   end

spec/react_on_rails/generators/install_generator_spec.rb

@@ -134,20 +134,23 @@
   context "when detecting Shakapacker installation" do
     let(:install_generator) { described_class.new }
 
-    context "shakapacker_installed?" do
+    context "when testing shakapacker_installed?" do
       specify "when Shakapacker gem is installed" do
-        mock_gem = double("gem_spec", version: double("version", segments: [7, 0, 0]))
+        mock_version = instance_double(Gem::Version, segments: [7, 0, 0])
+        mock_gem = instance_double(Gem::Specification, version: mock_version)
         allow(Gem::Specification).to receive(:find_by_name).with("shakapacker").and_return(mock_gem)
         expect(install_generator.send(:shakapacker_installed?)).to be true
       end
 
       specify "when Shakapacker gem is not installed" do
-        allow(Gem::Specification).to receive(:find_by_name).with("shakapacker").and_raise(Gem::MissingSpecError.new("gem", "spec"))
+        allow(Gem::Specification).to receive(:find_by_name).with("shakapacker").and_raise(Gem::MissingSpecError.new(
+                                                                                            "gem", "spec"
+                                                                                          ))
         expect(install_generator.send(:shakapacker_installed?)).to be false
       end
     end
 
-    context "ensure_shakapacker_installed" do
+    context "when testing ensure_shakapacker_installed" do
       specify "when Shakapacker is already installed" do
         allow(install_generator).to receive(:shakapacker_installed?).and_return(true)
         expect(install_generator).not_to receive(:system)
@@ -166,7 +169,9 @@
         allow(install_generator).to receive(:shakapacker_installed?).and_return(false)
         allow(install_generator).to receive(:system).with("rails shakapacker:install").and_return(false)
         expect(GeneratorMessages).to receive(:add_info).with("Shakapacker not detected. Installing Shakapacker...")
-        expect(GeneratorMessages).to receive(:add_error).with("Failed to install Shakapacker automatically. Please run 'rails shakapacker:install' manually.")
+        expect(GeneratorMessages).to receive(:add_error)
+          .with("Failed to install Shakapacker automatically. " \
+                "Please run 'rails shakapacker:install' manually.")
         install_generator.send(:ensure_shakapacker_installed)
       end
     end