Skip to content

Commit 8987ec9

Browse files
Simplify rspec-dummy-app-node-renderer to run all specs sequentially
Removed the problematic matrix sharding strategy that was splitting specs across 3 shards. The awk-based splitting logic may not have been running specs correctly. Now runs all RSpec specs sequentially in a single job, matching the simpler CircleCI behavior more closely. Changes: - Removed strategy.matrix.shard configuration - Changed from sharded runs to running all specs: bundle exec rspec - Added --profile 10 flag to match CircleCI - Removed --only-failures flag - Updated all artifact names to remove shard suffix: - pro-rspec-integration-results-shard${{ matrix.shard }} → pro-rspec-integration-results - pro-rspec-screenshots-shard${{ matrix.shard }} → pro-rspec-screenshots - pro-rspec-capybara-shard${{ matrix.shard }} → pro-rspec-capybara - pro-rspec-test-log-shard${{ matrix.shard }} → pro-rspec-test-log - pro-rspec-yarn-error-log-shard${{ matrix.shard }} → pro-rspec-yarn-error-log This ensures all specs run correctly without complex sharding logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 876e85c commit 8987ec9

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

.github/workflows/pro-integration-tests.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,6 @@ jobs:
9797
# RSpec integration tests with Node renderer
9898
rspec-dummy-app-node-renderer:
9999
needs: build-dummy-app-webpack-test-bundles
100-
strategy:
101-
fail-fast: false
102-
matrix:
103-
# Test parallelization - split tests across 3 shards
104-
shard: [1, 2, 3]
105100
runs-on: ubuntu-22.04
106101
env:
107102
REACT_ON_RAILS_PRO_LICENSE: ${{ secrets.REACT_ON_RAILS_PRO_LICENSE }}
@@ -213,51 +208,49 @@ jobs:
213208
- name: Wait for Rails server to start
214209
run: while ! curl -s http://localhost:3000 > /dev/null; do sleep 1; done
215210

216-
- name: Run RSpec tests for Pro dummy app (shard ${{ matrix.shard }}/3)
211+
- name: Run RSpec tests for Pro dummy app
217212
run: |
218213
cd spec/dummy
219-
SPEC_FILES=$(find spec -name '*_spec.rb' | sort | awk "NR % 3 == ${{ matrix.shard }} - 1")
220214
bundle exec rspec \
215+
--profile 10 \
221216
--format progress \
222217
--format RspecJunitFormatter \
223218
--out ~/rspec/rspec.xml \
224-
--format documentation \
225-
--only-failures \
226-
$SPEC_FILES
219+
--format documentation
227220
228221
- name: Store test results
229222
uses: actions/upload-artifact@v4
230223
if: always()
231224
with:
232-
name: pro-rspec-integration-results-shard${{ matrix.shard }}
225+
name: pro-rspec-integration-results
233226
path: ~/rspec
234227

235228
- name: Store screenshots
236229
uses: actions/upload-artifact@v4
237230
if: always()
238231
with:
239-
name: pro-rspec-screenshots-shard${{ matrix.shard }}
232+
name: pro-rspec-screenshots
240233
path: react_on_rails_pro/spec/dummy/tmp/screenshots
241234

242235
- name: Store Capybara artifacts
243236
uses: actions/upload-artifact@v4
244237
if: always()
245238
with:
246-
name: pro-rspec-capybara-shard${{ matrix.shard }}
239+
name: pro-rspec-capybara
247240
path: react_on_rails_pro/spec/dummy/tmp/capybara
248241

249242
- name: Store test log
250243
uses: actions/upload-artifact@v4
251244
if: always()
252245
with:
253-
name: pro-rspec-test-log-shard${{ matrix.shard }}
246+
name: pro-rspec-test-log
254247
path: react_on_rails_pro/spec/dummy/log/test.log
255248

256249
- name: Store yarn error log
257250
uses: actions/upload-artifact@v4
258251
if: failure()
259252
with:
260-
name: pro-rspec-yarn-error-log-shard${{ matrix.shard }}
253+
name: pro-rspec-yarn-error-log
261254
path: react_on_rails_pro/spec/dummy/yarn-error.log
262255

263256
# Playwright E2E tests with Redis service

0 commit comments

Comments
 (0)