Skip to content

Commit a26fd57

Browse files
committed
Fix problems with GitHub actions
1 parent 00a570e commit a26fd57

File tree

4 files changed

+12
-65
lines changed

4 files changed

+12
-65
lines changed

.github/workflows/examples.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
path: vendor/bundle
6262
key: package-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }}-${{ hashFiles('Gemfile.development_dependencies') }}-${{ matrix.versions }}
6363
- id: get-sha
64-
run: echo "::set-output name=sha::$(git rev-parse HEAD)"
64+
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
6565
- name: Install Node modules with Yarn for renderer package
6666
run: |
6767
yarn install --no-progress --no-emoji

.github/workflows/lint-js-and-ruby.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,11 @@ jobs:
6565
run: yarn start format.listDifferent
6666
- name: Type-check TypeScript
6767
run: yarn run type-check
68+
- name: Lint GitHub Actions
69+
# We only download and run Actionlint if there is any difference in GitHub Action workflows
70+
run: |
71+
if git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -q '^.github/workflows'; then
72+
bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
73+
./actionlint -color
74+
fi
75+
shell: bash

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
- name: Build test bundles for dummy app
7474
run: cd spec/dummy && rm -rf public/webpack/test && yarn run build:rescript && RAILS_ENV=test NODE_ENV=test bin/${{ matrix.versions == 'oldest' && 'web' || 'shaka' }}packer
7575
- id: get-sha
76-
run: echo "::set-output name=sha::$(git rev-parse HEAD)"
76+
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
7777
- name: Save test webpack bundles to cache (for build number checksum used by rspec job)
7878
uses: actions/cache/save@v4
7979
with:
@@ -133,7 +133,7 @@ jobs:
133133
path: spec/dummy/node_modules
134134
key: dummy-app-node-modules-cache-${{ hashFiles('spec/dummy/package.json') }}-${{ matrix.versions }}
135135
- id: get-sha
136-
run: echo "::set-output name=sha::$(git rev-parse HEAD)"
136+
run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT
137137
- name: Save test webpack bundles to cache (for build number checksum used by rspec job)
138138
uses: actions/cache@v4
139139
with:
@@ -158,7 +158,7 @@ jobs:
158158
echo -e "Already installed $(google-chrome --version)\n"
159159
MINIMUM_REQUIRED_CHROME_VERSION=75
160160
INSTALLED_CHROME_MAJOR_VERSION="$(google-chrome --version | tr ' .' '\t' | cut -f3)"
161-
if [[ $INSTALLED_CHROME_MAJOR_VERSION < $MINIMUM_REQUIRED_CHROME_VERSION ]]; then
161+
if [[ $INSTALLED_CHROME_MAJOR_VERSION -lt $MINIMUM_REQUIRED_CHROME_VERSION ]]; then
162162
wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
163163
sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
164164
sudo apt-get update

.travis.yml

Lines changed: 0 additions & 61 deletions
This file was deleted.

0 commit comments

Comments
 (0)