Skip to content

Commit aa76bc8

Browse files
committed
Fix duplicate messages in install generator
Fixes duplicate success messages in Redux generator and duplicate NPM install output by preventing double execution of generator methods.
1 parent f77bd54 commit aa76bc8

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/generators/react_on_rails/base_generator.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,11 @@ def add_js_dependencies
100100
add_react_dependencies
101101
add_css_dependencies
102102
add_dev_dependencies
103+
install_js_dependencies
103104
end
104105

106+
private
107+
105108
def install_js_dependencies
106109
# Detect which package manager to use
107110
success = if File.exist?(File.join(destination_root, "yarn.lock"))

lib/generators/react_on_rails/install_generator.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ def run_generators
4040
if installation_prerequisites_met? || options.ignore_warnings?
4141
invoke_generators
4242
add_bin_scripts
43-
add_post_install_message
43+
# Only add the post install message if not using Redux
44+
# Redux generator handles its own messages
45+
add_post_install_message unless options.redux?
4446
else
4547
error = <<~MSG.strip
4648
🚫 React on Rails generator prerequisites not met!

0 commit comments

Comments
 (0)