Skip to content

Commit ae50b3e

Browse files
Fix yarn cache and shellcheck issues in Pro workflows
This commit fixes two CI failures: 1. **Yarn cache error for execjs-compatible-dummy**: - Changed cache-dependency-path from single file to glob pattern - Now uses 'react_on_rails_pro/**/yarn.lock' to match all yarn.lock files - Matches pattern used in main package workflows - Fixes: Error: Could not get yarn cache folder path 2. **Shellcheck SC2209 warnings in background process commands**: - Added `true` after background process commands - Satisfies shellcheck requirement for explicit command success - Affects pro-integration-tests.yml lines 207-216, 384-393 All three Pro workflow files updated: - .github/workflows/pro-lint.yml - .github/workflows/pro-package-tests.yml - .github/workflows/pro-integration-tests.yml 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent c341502 commit ae50b3e

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

.github/workflows/pro-integration-tests.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
with:
3333
node-version: 22
3434
cache: yarn
35-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
35+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
3636

3737
- name: Print system information
3838
run: |
@@ -121,7 +121,7 @@ jobs:
121121
with:
122122
node-version: 22
123123
cache: yarn
124-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
124+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
125125

126126
- name: Print system information
127127
run: |
@@ -208,11 +208,13 @@ jobs:
208208
run: |
209209
cd spec/dummy
210210
yarn run node-renderer &
211+
true
211212
212213
- name: Run Rails server in background
213214
run: |
214215
cd spec/dummy
215216
RAILS_ENV=test rails server &
217+
true
216218
217219
- name: Wait for Rails server to start
218220
run: |
@@ -298,7 +300,7 @@ jobs:
298300
with:
299301
node-version: 22
300302
cache: yarn
301-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
303+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
302304

303305
- name: Print system information
304306
run: |
@@ -385,11 +387,13 @@ jobs:
385387
run: |
386388
cd spec/dummy
387389
yarn run node-renderer &
390+
true
388391
389392
- name: Run Rails server in background
390393
run: |
391394
cd spec/dummy
392395
RAILS_ENV=test rails server &
396+
true
393397
394398
- name: Wait for Rails server to start
395399
run: |

.github/workflows/pro-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
with:
3232
node-version: 22
3333
cache: yarn
34-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
34+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
3535

3636
- name: Print system information
3737
run: |

.github/workflows/pro-package-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
with:
3333
node-version: 22
3434
cache: yarn
35-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
35+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
3636

3737
- name: Print system information
3838
run: |
@@ -113,7 +113,7 @@ jobs:
113113
with:
114114
node-version: ${{ matrix.node-version }}
115115
cache: yarn
116-
cache-dependency-path: 'react_on_rails_pro/yarn.lock'
116+
cache-dependency-path: 'react_on_rails_pro/**/yarn.lock'
117117

118118
- name: Print system information
119119
run: |

0 commit comments

Comments
 (0)