Skip to content

Commit ae63ff6

Browse files
justin808claude
andcommitted
Fix test configuration for immediate_hydration default change
- Set immediate_hydration: true in test setup to match test expectations - Update test expectations to use data-immediate-hydration attribute - Add proper before/after hooks to manage test configuration - Reduces test failures from 10 to 2 (remaining failures unrelated to immediate_hydration) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 1ec28d2 commit ae63ff6

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,18 @@ class PlainReactOnRailsHelper
2525
allow(ReactOnRails::Utils).to receive_messages(
2626
react_on_rails_pro_licence_valid?: true
2727
)
28+
29+
# Configure immediate_hydration to true for tests since they expect that behavior
30+
ReactOnRails.configure do |config|
31+
config.immediate_hydration = true
32+
end
33+
end
34+
35+
after do
36+
# Reset to default
37+
ReactOnRails.configure do |config|
38+
config.immediate_hydration = false
39+
end
2840
end
2941

3042
let(:hash) do
@@ -199,7 +211,7 @@ def helper.append_javascript_pack_tag(name, **options)
199211
<script type="application/json" class="js-react-on-rails-component" \
200212
id="js-react-on-rails-component-App-react-component" \
201213
data-component-name="App" data-dom-id="App-react-component"
202-
data-force-load="true">{"name":"My Test Name"}</script>
214+
data-immediate-hydration="true">{"name":"My Test Name"}</script>
203215
SCRIPT
204216
end
205217

@@ -208,7 +220,7 @@ def helper.append_javascript_pack_tag(name, **options)
208220
<script type="application/json" class="js-react-on-rails-component" \
209221
id="js-react-on-rails-component-App-react-component" \
210222
data-component-name="App" data-dom-id="App-react-component"
211-
data-force-load="true">{}</script>
223+
data-immediate-hydration="true">{}</script>
212224
SCRIPT
213225
end
214226

@@ -257,7 +269,7 @@ def helper.append_javascript_pack_tag(name, **options)
257269
<script type="application/json" class="js-react-on-rails-component" \
258270
id="js-react-on-rails-component-App-react-component" \
259271
data-component-name="App" data-dom-id="App-react-component"
260-
data-force-load="true">{"name":"My Test Name"}</script>
272+
data-immediate-hydration="true">{"name":"My Test Name"}</script>
261273
SCRIPT
262274
end
263275

@@ -273,7 +285,7 @@ def helper.append_javascript_pack_tag(name, **options)
273285
<script type="application/json" class="js-react-on-rails-component" \
274286
id="js-react-on-rails-component-App-react-component-0" \
275287
data-component-name="App" data-dom-id="App-react-component-0"
276-
data-force-load="true">{"name":"My Test Name"}</script>
288+
data-immediate-hydration="true">{"name":"My Test Name"}</script>
277289
SCRIPT
278290
end
279291

@@ -295,7 +307,7 @@ def helper.append_javascript_pack_tag(name, **options)
295307
<script type="application/json" class="js-react-on-rails-component" \
296308
id="js-react-on-rails-component-App-react-component" \
297309
data-component-name="App" data-dom-id="App-react-component"
298-
data-force-load="true">{"name":"My Test Name"}</script>
310+
data-immediate-hydration="true">{"name":"My Test Name"}</script>
299311
SCRIPT
300312
end
301313

@@ -313,7 +325,7 @@ def helper.append_javascript_pack_tag(name, **options)
313325
<script type="application/json" class="js-react-on-rails-component" \
314326
id="js-react-on-rails-component-shaka_div" \
315327
data-component-name="App" data-dom-id="shaka_div"
316-
data-force-load="true">{"name":"My Test Name"}</script>
328+
data-immediate-hydration="true">{"name":"My Test Name"}</script>
317329
SCRIPT
318330
end
319331

@@ -511,7 +523,7 @@ def helper.append_javascript_pack_tag(name, **options)
511523
end
512524

513525
let(:react_store_script) do
514-
'<script type="application/json" data-js-react-on-rails-store="reduxStore" data-force-load="true">' \
526+
'<script type="application/json" data-js-react-on-rails-store="reduxStore" data-immediate-hydration="true">' \
515527
'{"name":"My Test Name"}' \
516528
"</script>"
517529
end

0 commit comments

Comments
 (0)