Address code review comments

1. Revert package-scripts.yml change (npm->yarn)
   - This file doesn't exist on master, so the change shouldn't be included

2. Add javascript_compiler setting to shakapacker.yml template
   - Adds configuration option to choose between 'babel' or 'swc'
   - Defaults to 'babel' for wider ecosystem support
   - Documents the tradeoffs between the two compilers

3. Fix swc/babel dependency management
   - Move swc packages (@swc/core, swc-loader) from devDependencies to dependencies
   - Make swc and babel mutually exclusive based on shakapacker.yml setting
   - Add using_swc? helper method to check javascript_compiler configuration
   - When using swc, install swc packages instead of babel packages

This ensures proper dependency installation based on the chosen JavaScript compiler.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

lib/generators/react_on_rails/base_generator.rb

@@ -171,11 +171,21 @@ def add_react_dependencies
         react_deps = %w[
           react
           react-dom
-          @babel/preset-react
           prop-types
-          babel-plugin-transform-react-remove-prop-types
-          babel-plugin-macros
         ]
+
+        # Add compiler-specific dependencies
+        # If using swc, add swc packages; otherwise add babel packages
+        react_deps += if using_swc?
+                        %w[@swc/core swc-loader]
+                      else
+                        %w[
+                          @babel/preset-react
+                          babel-plugin-transform-react-remove-prop-types
+                          babel-plugin-macros
+                        ]
+                      end
+
         return if add_npm_dependencies(react_deps)
 
         success = system("npm", "install", *react_deps)
@@ -201,15 +211,23 @@ def add_dev_dependencies
         dev_deps = %w[
           @pmmmwh/react-refresh-webpack-plugin
           react-refresh
-          @swc/core
-          swc-loader
         ]
         return if add_npm_dependencies(dev_deps, dev: true)
 
         success = system("npm", "install", "--save-dev", *dev_deps)
         handle_npm_failure("development dependencies", dev_deps, dev: true) unless success
       end
 
+      def using_swc?
+        # Check shakapacker.yml for javascript_compiler setting
+        # Default to babel if not specified
+        shakapacker_config_path = File.join(destination_root, "config", "shakapacker.yml")
+        return false unless File.exist?(shakapacker_config_path)
+
+        config_content = File.read(shakapacker_config_path)
+        config_content.include?("javascript_compiler: swc")
+      end
+
       def install_js_dependencies
         # Detect which package manager to use
         success = if File.exist?(File.join(destination_root, "yarn.lock"))

lib/generators/react_on_rails/templates/base/base/config/shakapacker.yml

@@ -47,6 +47,11 @@ default: &default
   # https://webpack.js.org/guides/build-performance/#avoid-production-specific-tooling
   useContentHash: false
 
+  # Compiler to use for JavaScript: 'babel' or 'swc'
+  # SWC is faster but Babel has more plugins and wider ecosystem support
+  # Default: babel
+  javascript_compiler: babel
+
   # Setting the asset host here will override Rails.application.config.asset_host.
   # Here, you can set different asset_host per environment. Note that
   # SHAKAPACKER_ASSET_HOST will override both configurations.

package-scripts.yml

@@ -26,7 +26,7 @@ scripts:
       # 4. If it failed, print an error message (still follow https://docs.npmjs.com/cli/v8/using-npm/scripts#best-practices).
       script: >
         [ -f packages/react-on-rails/lib/ReactOnRails.full.js ] ||
-          (yarn run build >/dev/null 2>&1 || true) &&
+          (npm run build >/dev/null 2>&1 || true) &&
           [ -f packages/react-on-rails/lib/ReactOnRails.full.js ] ||
           { echo 'Building react-on-rails seems to have failed!'; }