Skip to content

Commit d31e517

Browse files
committed
Fix duplicate messages in install generator
Fixes duplicate success messages in Redux generator and duplicate NPM install output by preventing double execution of generator methods.
1 parent 99044da commit d31e517

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/generators/react_on_rails/base_generator.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,11 @@ def add_js_dependencies
100100
add_react_dependencies
101101
add_css_dependencies
102102
add_dev_dependencies
103+
install_js_dependencies
103104
end
104105

106+
private
107+
105108
def install_js_dependencies
106109
# Detect which package manager to use
107110
success = if File.exist?(File.join(destination_root, "yarn.lock"))

lib/generators/react_on_rails/install_generator.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ def run_generators
3232
if installation_prerequisites_met? || options.ignore_warnings?
3333
invoke_generators
3434
add_bin_scripts
35-
add_post_install_message
35+
# Only add the post install message if not using Redux
36+
# Redux generator handles its own messages
37+
add_post_install_message unless options.redux?
3638
else
3739
error = <<~MSG.strip
3840
🚫 React on Rails generator prerequisites not met!

0 commit comments

Comments
 (0)