Skip to content

Commit f8bee7e

Browse files
linting
1 parent 05cf748 commit f8bee7e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

docs/release-notes/15.0.0.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Major improvements to component and store hydration:
2626
- New configuration option `generated_component_packs_loading_strategy` replaces `defer_generated_component_packs`
2727
- Supports three loading strategies:
2828
- `:async` - Loads scripts asynchronously (default for Shakapacker ≥ 8.2.0)
29-
- `:defer` - Defers script execution until after page load (Doesn't work good with Streamed HTML as it will wait for the full page load before hydrating the components)
29+
- `:defer` - Defers script execution until after page load (Doesn't work well with Streamed HTML as it will wait for the full page load before hydrating the components)
3030
- `:sync` - Loads scripts synchronously (default for Shakapacker < 8.2.0) (Better to upgrade to Shakapacker 8.2.0 and use `:async` strategy)
3131
- Improves page performance by optimizing how component packs are loaded
3232

@@ -92,12 +92,12 @@ Explicitly declare store dependencies for each component:
9292
```erb
9393
<% redux_store("SimpleStore", props: @app_props_server_render, defer: true) %>
9494
<%= react_component('ReduxApp', {}, {
95-
prerender: true
96-
<!-- No need to specify store_dependencies - it automatically depends on SimpleStore -->
95+
prerender: true
96+
<!-- No need to specify store_dependencies - it automatically depends on SimpleStore -->
9797
}) %>
9898
<%= react_component('ComponentWithNoStore', {}, {
99-
prerender: true,
100-
store_dependencies: [] <!-- Explicitly declare no store dependencies -->
99+
prerender: true,
100+
store_dependencies: [] <!-- Explicitly declare no store dependencies -->
101101
}) %>
102102
<%= redux_store_hydration_data %>
103103
```

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ class PlainReactOnRailsHelper
7575
def helper.append_javascript_pack_tag(name, **options)
7676
original_append_javascript_pack_tag.call(name, **options)
7777
end
78+
7879
allow(helper).to receive(:append_javascript_pack_tag)
7980
allow(helper).to receive(:append_stylesheet_pack_tag)
8081
expect { helper.load_pack_for_generated_component("component_name", render_options) }.not_to raise_error

0 commit comments

Comments
 (0)