-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with Macvim #4
Comments
Ha I originally used chokidar but it has it's own set of issues (unlink doesnt fire on osx, fires add events when just adding files to be watched/at start up, no tests, ignores folders, maintainer is busy). So I built gaze and fixed all those issues. Also chokidar matched too many files and we had to check if the file matched after the event... rather then before like gaze does. So It's more efficient having file matching built in. I also considered https://github.com/medikoo/fs2 but it doesn't support node v0.6 (which neither does Grunt v0.4 now) and it was slower. It's still in development so I may reconsider it later. But for now, gaze must handle the low level stuff.
|
Actually you already had a TODO note for L341 (And it was L339). Both method are setup when forceWatchMethod is false, which is a bit strange. Try to test with macvim or (vim/vi). I'had this kind of fs.watch issues with derby.js and socketstream and it was only fixed when they moved to chokidar. I've started to wonder, if it is weird side effects of using encrypted drives. I saw this nodejs/node-v0.x-archive#3343, hopefully should be better with node 0.9. |
I wonder if it is the same issue as this gruntjs/grunt-contrib-watch#13. What version of OSX are you running? I'm running on 10.6 atm but am going to try to upgrade soon to look into this. I have gaze by default use both Thanks for reporting btw. |
Am running the latest stable osx/node, but it is not OSX version dependent, I have been having this kind of issue for a long time, it's why I am wondering wether It has something to do with using encrypted drive, since some people don't have the issue at all while others do. Am now trying to do a fix similar to coffeescript, this rewatch thing works. Fix here, added a rewatch option to the new method. 754d47d |
That rewatch fix works for me and is substantially faster than using |
I think I finally understand the real issue here to write a test case to duplicate. If @sebv wanted to open a PR it would be greatly appreciated! |
Here is a test to simulate a safe write event: 8f6c61e8d825d72730715d5c1b9ccfbfd092f038 |
This is how socketstream dealt with it: socketstream/socketstream@8785805 |
@jgallen23 Thanks! Will use that as reference. |
Couple of things:
The text was updated successfully, but these errors were encountered: