Skip to content

Commit 61cf4e4

Browse files
author
Xinyu Liu
committed
SAMZA-1171: Rewrite config in ApplicationRunnerMain when creating ApplicationRunner
The config needs to be rewritten before passing down to the ApplicationRunner. This is a bug that was introduced during some refactoring/cleanup of the config in the ApplicationRunner interface. Author: Xinyu Liu <xiliu@xiliu-ld.linkedin.biz> Reviewers: Jacob Maes <jmakes@apache.org> Closes apache#98 from xinyuiscool/SAMZA-1171
1 parent e4cfeeb commit 61cf4e4

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,15 @@ public class ApplicationRunnerMain {
3939
public static void main(String[] args) throws Exception {
4040
CommandLine cmdLine = new CommandLine();
4141
OptionSet options = cmdLine.parser().parse(args);
42-
Config config = cmdLine.loadConfig(options);
42+
Config orgConfig = cmdLine.loadConfig(options);
43+
Config config = Util.rewriteConfig(orgConfig);
4344

4445
if (config.containsKey(STREAM_APPLICATION_CLASS_CONFIG)) {
4546
ApplicationRunner runner = ApplicationRunner.fromConfig(config);
4647
StreamApplication app = (StreamApplication) Class.forName(config.get(STREAM_APPLICATION_CLASS_CONFIG)).newInstance();
4748
runner.run(app);
4849
} else {
49-
new JobRunner(Util.rewriteConfig(config)).run(true);
50+
new JobRunner(config).run(true);
5051
}
5152
}
5253
}

0 commit comments

Comments
 (0)