Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapters should return concrete wallet types #455

Closed
mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #418
Closed

Adapters should return concrete wallet types #455

mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #418
Labels
tech-debt A suboptimality that existed in code when it was written.

Comments

@mrnerdhair
Copy link
Contributor

mrnerdhair commented Mar 14, 2022 •
edited
Loading

The various wallet adapters return wallet instances typed as core.HDWallet instead of the specific type of each wallets. This forces users to use type guards unnecessarily (or, practically, just to use a type assertion and kill a kitten).

  • Each adapter should return the specific type of the wallet it constructs.

Fixed by #418.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 25, 2022 that will close this issue
return actual types from adapter.pairDevice() #418
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return actual types from adapter.pairDevice() shapeshift/hdwallet
1 participant
@mrnerdhair