Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portis/MM don't always use async functions #456

Closed
mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #419
Closed

Portis/MM don't always use async functions #456

mrnerdhair opened this issue Mar 14, 2022 · 0 comments · Fixed by #419
Labels
tech-debt A suboptimality that existed in code when it was written.

Comments

@mrnerdhair
Copy link
Contributor

For legacy reasons, hdwallet-portis and hdwallet-metamask have various functions which return explicitly constructed Promises instead of using async functions. These should all be modernized to use async functions.

Fixed by #419.
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 17, 2022 that will close this issue
use async functions for portis/metamask #419
Merged
@mrnerdhair mrnerdhair mentioned this issue Apr 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use async functions for portis/metamask shapeshift/hdwallet
1 participant
@mrnerdhair