Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en translation fix for ReviewForm.reviewRatingRequired #1011

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

Schwerbelastung
Copy link
Contributor

No description provided.

@lyyder
Copy link
Contributor

lyyder commented Jan 25, 2019

It seems that this message is never visible, which is probably why it's been wrong all along. It's used in the ReviewForm component and I don't think the submit button for the form is enabled before the rating value is provided. And there is now way to focus the review start input and then leave it empty, which would render this message.

A sidenote/question: Is the fact that the FieldReviewRating component can't be navigated into with TAB an accessibility issue and/or does it make the component inconsistent in regard to other input fields?

@Gnito
Copy link
Contributor

Gnito commented Jan 25, 2019

@lyyder, yeah. It is an accessibility problem. There should be tabindex=0 in the <label> elements + some keyboard listener attached to them too. (It's just hard to find good time to fix this.)

What comes to an error message: our template app doesn't need it but it's good to have error handling ready in every Field* input.

@Schwerbelastung
Copy link
Contributor Author

Schwerbelastung commented Jan 25, 2019

And it's one less mistake that any outsider can find in our code :)

@Gnito Gnito merged commit c6306fc into master Jan 28, 2019
@Gnito Gnito deleted the ftw-translation-fix branch January 28, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants