-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword search #1129
Merged
Merged
Add keyword search #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
keyword-search-filter-desktop
branch
3 times, most recently
from
July 9, 2019 10:06
31e31c9
to
e71a108
Compare
OtterleyW
commented
Jul 11, 2019
OtterleyW
commented
Jul 11, 2019
Gnito
force-pushed
the
keyword-search-filter-desktop
branch
2 times, most recently
from
July 16, 2019 18:54
ca501e8
to
5ab7610
Compare
Gnito
force-pushed
the
keyword-search-filter-desktop
branch
from
July 17, 2019 15:47
aedfea5
to
b572284
Compare
Gnito
force-pushed
the
keyword-search-filter-desktop
branch
2 times, most recently
from
July 18, 2019 08:58
8c7ae31
to
500155c
Compare
Add it to desktop and mobile layout
Gnito
force-pushed
the
keyword-search-filter-desktop
branch
from
July 18, 2019 14:38
500155c
to
8cf99fd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keyword search components to
SearchFilters.js
andSearchFiltersMobile.js
. On mobile live edit is in use so we need to use debounce inFilterForm.js
so that the query is made after the user has stopped typing.On desktop:
On mobile: