Fix Topbar search initial value #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Jun 29, 2018
src/components/Topbar/Topbar.js
Outdated
| @@ -174,7 +174,7 @@ class TopbarComponent extends Component { | |||
| ); | |||
|
|
|||
| // Only render current search if full place object is available in the URL params | |||
| const locationFieldsPresent = address && origin && bounds && country; | |||
| const locationFieldsPresent = address && bounds && country; | |||
There was a problem hiding this comment.
const originNeedChecked = config.sortSearchByDistance && origin || !config.sortSearchByDistance;
or something like this
There was a problem hiding this comment.
@Gnito updated this, didn't match your proposal but I think the idea is the same.
Gnito
approved these changes
Jun 29, 2018
Require origin to be passed to search input in case search results are sorted by distance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes showing the searched address in the Topbar search form after a search conducted from the Topbar.
Makes the
originattribute optional inpropTypes.placein src/util/types.js as it is not used in case thesortSearchByDistanceis not set in config.