Reorganize maps configuration #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpuputti
force-pushed
the
reorganise-maps-config
branch
4 times, most recently
from
7b6c989
to
62053d1
Compare
lyyder
reviewed
Aug 17, 2018
| // obfuscated coordinates are withing a circle that has the same | ||
| // radius as the offset. | ||
| coordinateOffset: 500, | ||
| const maps = { |
There was a problem hiding this comment.
We could call this map as the application is using one map at a time. But I guess maps makes sense too.
There was a problem hiding this comment.
Well, you sort of configure all the maps in the app. And nothing prevents using two or more maps at a time. But mainly maps is a bit more greppable than map.
lyyder
approved these changes
Aug 17, 2018
lyyder
force-pushed
the
reorganise-maps-config
branch
from
62053d1
to
8926411
Compare
|
Merging this so that we can base the actual Mapbox changes on top of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
This PR reorganises the maps configuration to work with both Google Maps and Mapbox. The structure of the configuration is different and paves the way for the bigger change of making Mapbox as the default map provider.
NOTE: Can we merge this already? This will create conflicts if people have edited the related settings in
config.js. Although multiple smaller breaking changes is better than one huge one when the whole Mapbox feature lands.Update docs(another PR)