Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pager through config file. #362

Closed
eth-p opened this issue Oct 18, 2018 · 4 comments
Closed

Set pager through config file. #362

eth-p opened this issue Oct 18, 2018 · 4 comments
Labels
feature-request New feature or request good first issue Good for newcomers

Comments

@eth-p
Copy link
Collaborator

eth-p commented Oct 18, 2018

As of bat 0.8, there doesn't currently seem to be any way to set the pager aside from the BAT_PAGER environment variable. If we added a --pager argument, the pager could be configured through the bat config file.

  • Should this be added?
  • IF so, should the --pager argument be hidden from --help?
@eth-p eth-p changed the title Configure pager through config file. Set pager through config file. Oct 18, 2018
@sharkdp
Copy link
Owner

sharkdp commented Oct 18, 2018

  • Should this be added?

Yes! I had the same thought yesterday. Thank you for opening this ticket.

  • IF so, should the --pager argument be hidden from --help?

Hm.. maybe we can set .hidden_short_help(true) such that it will not appear in -h help text, but still be visible in the --help text. We should actually do the same for the --config-file and --no-config arguments.

@sharkdp sharkdp added feature-request New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 18, 2018
@majecty
Copy link
Contributor

majecty commented Oct 21, 2018

If there's no work in progress, I would like to take this issue.

@sharkdp
Copy link
Owner

sharkdp commented Oct 21, 2018

@majecty Sounds great! I don't think there is any work in progress so far.

@majecty majecty mentioned this issue Oct 21, 2018
Merged
@sharkdp
Copy link
Owner

sharkdp commented Nov 11, 2018

This is now available in bat 0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@majecty @sharkdp @eth-p