Federated (Facebook/Google) Login Always Shows 'Facebook Login' in Title

[CircuitByrd]

When logging in using a third party identity provider, the option of Facebook or Google exists.
If Google is selected, the Google login interface is correctly displayed in the frame, but the title of the window is 'Facebook Login'.
This could confuse users or erode trust.

[CircuitByrd]

This looks like an easy fix: minigalaxy/ui/login.py
Line 45 defines the title for "any pop-up windows during authentication" as "Facebook Login"
This could be made more generic, such as "SSO Login" "Third Party Login" "Federated Login" etc.

[GB609]

I think we could also add a listener to the webview and take the title of the target url instead.
This way we take full advantage of the the webview output which should already be localized by the browser/server.

Something like

 def on_create(self, widget, action):
        popup = Gtk.Dialog(title=_("Login"), parent=self, flags=0, buttons=())
        webview = WebKit2.WebView.new_with_related_view(widget)
        change_dialog_title = lambda : popup.set_title(webview.get_title())
        webview.connect('notify::title', change_dialog_title)
        webview.load_uri(action.get_request().get_uri())
        webview.__dict__['popup'] = popup
        webview.connect('close', self.on_close_popup)
        popup.get_content_area().pack_start(webview, True, True, 0)
        popup.set_size_request(400, 600)
        popup.set_modal(True)
        popup.show_all()
        return webview

I'm going to run a little test for that once i have the time.

[sharkwouter]

Thanks for bringing this up, I wasn't aware. I'd take a PR for either of these solutions.

[sharkwouter]

The reason it was like that is that before Facebook was the only additional way to authenticate.

[GB609]

I've created a pull request for this little fix: #638.
But i didn't see an option to use facebook for login. I could only see google and discord.
Has facebook been dropped?