Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named readtables #5

Open
ruricolist opened this issue Sep 29, 2018 · 2 comments
Open

Named readtables #5

ruricolist opened this issue Sep 29, 2018 · 2 comments

Comments

@ruricolist
Copy link
Contributor

I'd like to propose switching CXML to use named-readtables. It would allow removing the component classes from the .asd file, moving it in a much more declarative direction.

This isn't technically challenging (I already did it for FXML) but it would require a coordinated change across closure-common and CXML so I wanted to raise it for discussion first.

You can see the contemplated changes in these commits:

ruricolist/FXML@fd1ffd9
ruricolist/FXML@fd1ffd9
@slyrus
Copy link
Member

slyrus commented Sep 29, 2018

I'm all for it!

@scymtym
Copy link
Member

scymtym commented Sep 30, 2018

I'm all for it!

Same.

You can see the contemplated changes in these commits:

ruricolist/FXML@fd1ffd9
ruricolist/FXML@fd1ffd9

Both links point to the same commit. That commit lgtm, though.

@ruricolist Since we all agree about wanting this, would you make a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scymtym @slyrus @ruricolist