Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxies: EIP1967Proxy is not being detected for Compound USDCv3 #126

Open
shazow opened this issue Sep 24, 2024 · 1 comment · May be fixed by #129
Open

proxies: EIP1967Proxy is not being detected for Compound USDCv3 #126

shazow opened this issue Sep 24, 2024 · 1 comment · May be fixed by #129
Labels
bug Something isn't working

Comments

@shazow
Copy link
Owner

shazow commented Sep 24, 2024

https://etherscan.io/address/0xc3d688b66703497daa19211eedff47f25384cdc3

It's supposed to be a ERC1967Proxy but for some reason the constant slots we used to identify it are missing from the bytecode (got compiled out? optimized?).

Need to figure out why.

Worst case could also fall back to checking for an implementation() selector (0x5c60da1b?).

Via #125
@shazow shazow added the bug Something isn't working label Sep 24, 2024
@shazow shazow mentioned this issue Sep 24, 2024
Closed
@shazow
Copy link
Owner Author

shazow commented Sep 25, 2024

Looks like the constant we're looking for is stored at the end and loaded via CODECOPY, and whatsabi is failing to detect the end of the program so it's treating it as instructions.

@shazow shazow linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: disasm: Detect code boundary and look for slots in aux data shazow/whatsabi
1 participant
@shazow