Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HorizonsID_type should default to None #56

Open
cbender opened this issue Jan 28, 2023 · 1 comment
Open

HorizonsID_type should default to None #56

cbender opened this issue Jan 28, 2023 · 1 comment

Comments

@cbender
Copy link

cbender commented Jan 28, 2023

Astroquery v0.4.4 onward default id_type = None to search for major bodies first. Documentation should be updated here:

> 'majorbody' refers to planets or satellites. Use for Moon.

The desired search behavior for small bodies is passed throughout barycorrpy via the HorizonsID_type keyword. However, reflected light call to get Solar offset is still hard coded here:

SolObj2 = Horizons(id='Sun', location='@0', epochs=JDTDB-(TargetSolLightTravelDelay), id_type='majorbody')

@shbhuk
Copy link
Owner

shbhuk commented Jan 28, 2023

I'll need to double-check this. My recollection is the line 251 quoted above is getting the Solar position vector wrt the SSB, and hence the id_type = 'majorbody'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants