Skip to content
This repository has been archived by the owner on Oct 20, 2018. It is now read-only.

Nested carousels #42

Closed
iamlothian opened this issue Nov 6, 2017 · 4 comments
Closed

Nested carousels #42

iamlothian opened this issue Nov 6, 2017 · 4 comments

Comments

@iamlothian
Copy link
Contributor

iamlothian commented Nov 6, 2017

I noticed two issues when nesting carousels, which was likely not an intended feature, but i believe it to be possible.

  1. It seems as though the nested carousel picks up the [input] value of the parent carousel rather than using its own. In my case (Which i will attempt to reproduce in an isolated sample) An outer Tile carousel causes and inner item carousel to become tiles and use the same grid definition.

  2. touch events are propagated from the nested carousel to the parent resulting in both handling the scroll touch events.

EDIT: as promised Plunker

@sheikalthaf
Copy link
Owner

Nice suggestion.
In your first point the nested carousel doesn't picks input of the parent.
In my carousel css i'm point the item selector as autogenerated id and .item class.
but css taking parent autogenerated id and child .tem class, Due to this the parent css applied to the child carousel. This issue will be fixed in next update.
Second point:
don't have any idea how to solve this

@sheikalthaf
Copy link
Owner

sheikalthaf commented Nov 7, 2017

I need help to solve this issue #20 . Do you know how to solve this issue? It's all about hammerjs

@iamlothian
Copy link
Contributor Author

I'll try have a look at this.

@sheikalthaf
Copy link
Owner

@iamlothian thanks for helping to fix issues. read the changelog file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants