You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Thank you for this piece of work. I noticed a mistake in your rotation matrix computation (part of the Kabsch algorithm for alignment) here:
# Rotation matrix
R = V.mm(U.T)
should be replaced with
# Rotation matrix
R = V.mm(U.T)
# Ensure R is a proper rotation matrix
if torch.det(R) < 0: # reflection
V[:, -1] *= -1 # flip the sign of the last column of V
R = V.mm(U.T)
Hi! Thank you for this piece of work. I noticed a mistake in your rotation matrix computation (part of the Kabsch algorithm for alignment) here:
should be replaced with
See this link for justification
The text was updated successfully, but these errors were encountered: